arch1t3cht / Aegisub

Cross-platform advanced subtitle editor, with new feature branches. Read the README on the feature branch.
http://www.aegisub.org
Other
738 stars 32 forks source link

Import German translation from wangqr #52

Closed TheOneric closed 1 year ago

TheOneric commented 1 year ago

The current meson integration for POT generation is incomplete and misses out a lot of strings. The last commit improves this for strings from C++ source files, but strings from other sources are still missing. For *.xml and *.desktop adding support might be as simple as renaming to .in.in instead of .template.in and dropping any extra underscores added for intltool. Re packages/desktop/aegisub.appdata.xml.template.in also see [issue creation pending]. For the remaining formats I have no idea what the best way to integrate them is.

For this PR’s POT and PO update, I therefore stuck with make_pot.sh and msgmerge. If you’d prefer keeping the changeset down, I can omit rebasing non-de PO files to the new POT version.

Cosmetic nit: it might be a good idea to unify the (original) message texts for ffms2 and bestsource’s keyframe and timecode indexing/scanning dialogue.

TheOneric commented 1 year ago

Found a way to make aegisub.appdata.xml build with i18n afterall and also discovered the existing .desktop integration is borked. The latter also affects the POT update here, so converted to draft. I’ll fix this up and add the desktop and appdata stuff to this PR later.

TheOneric commented 1 year ago

Fixed desktop file string extraction and added meson integration for desktop and appdata files + updating obsolete links in aegisub.appdata.xml. Should be ready for review.

Remaining future improvements for someone more familiar with meson i18n details and the build setup:

arch1t3cht commented 1 year ago

Thanks a lot! This mostly LGTM except for a few corrections on the added German translations.

I did also update some of the bestsource messages (actually this was long overdue since some of them were carried over from back when it was still a proof-of-concept and never updated) in 0c057ebddb1b28780a1d70bbc9f6d6d48a25f554, though I still kept some of them. I replaced "Exacting" with "Indexing" and "Finding Keyframes and Timecodes..." with "Reading timecodes and frame/sample data" (this isn't strictly accurate since bestsource doesn't read samples here, but it probably still makes the most sense for the user), but I kept "Scanning" as it is since that is a separate step that (for now) needs to run every time the file is opened, as opposed to the Indexing step that only needs to happen once per file.

TheOneric commented 1 year ago

Thanks for the review! Translations are now fixed as suggested and rebased for the new BS source strings. To make backporting to wangqr easier I split fixing existing translations from wangqr into a separate commit. As a bonus I found and fixed another mistake in the old 2013 translations (WahlenWählen).

New version now also includes other make_pot.sh improvements from wangqr and some new additional improvements. Some noteworthy points:

Future improvements not in scope of this PR:


New changes which can be backported to wangqr/Aegisub afterwards:

arch1t3cht commented 1 year ago

Thanks again! There was one more missing space in the VapourSynth description text, but I just fixed that myself.