search

arch1t3cht / Aegisub

Cross-platform advanced subtitle editor, with new feature branches. Read the README on the feature branch.
http://www.aegisub.org
Other
738 stars 32 forks source link

bas or bs? #65

Closed 0tkl closed 6 months ago

0tkl commented 1 year ago

When I'm packaging your release to aegisub-arch1t3cht, I'm a bit confused about the dependencies in the code: it depends on VapourSynth BestAudioSource plugin (bas) in somewhere, but BestSource plugin (bs) in other places.

I notice that bas seems to be the predecessor of bs, and bas had been archived in 2022. I tried to migrate from bas to bs (see https://github.com/arch1t3cht/Aegisub/commit/23451d4), and it works fine on my Linux. Could we migrate from bas to bs (after testing on Windows and macOS)?

arch1t3cht commented 1 year ago

Yes, bs is the successor to bas and generally recommended to be used instead. The only reason why I'm not moving to it as the default yet is that it doesn't have any official builds available (only beta builds from doom9).

AFAIK the actual vapoursynth plugin bs isn't actually used anywhere (by default), it's only bas and the BestSource library, since that can easily be built and linked against the ffmpeg wrap.

If the problem with there being no official bs plugin builds persists even longer, I might eventually just set up a compile workflow for it myself, but I didn't get around to it yet.

hooke007 commented 1 year ago

win build https://github.com/vapoursynth/bestsource/actions/runs/5531102539

0tkl commented 6 months ago

https://github.com/vapoursynth/bestsource/releases/tag/R1-RC1

arch1t3cht commented 6 months ago

Yeah, I'll wait and see if there'll be a proper (non-RC) release soon. If not, I'll just ship the RC1.