libaegisub: Avoid calling iconv_close(iconv_invalid)

arch1t3cht / Aegisub

Cross-platform advanced subtitle editor, with new feature branches. Read the README on the feature branch.

http://www.aegisub.org

Other

738 stars 32 forks source link

libaegisub: Avoid calling iconv_close(iconv_invalid) #74

Closed al3xtjames closed 12 months ago

al3xtjames commented 1 year ago

IsConversionSupported unconditionally calls iconv_close on the descriptor returned by iconv_open. This may result in crashes if iconv_open returns iconv_invalid.

arch1t3cht commented 12 months ago

Merged in https://github.com/arch1t3cht/Aegisub/commit/4f67db8dd732efbace81aa57260b6575fe86dd55, thanks!