arch1t3cht / Aegisub

Cross-platform advanced subtitle editor, with new feature branches. Read the README on the feature branch.
http://www.aegisub.org
Other
738 stars 32 forks source link

Update Korean translation #75

Open Hackjjang opened 1 year ago

Hackjjang commented 1 year ago

image

I'd like to contribute to making the tool more accessible to people with Korean accessibility.

Hackjjang commented 11 months ago

Is there a specific reason why it won't merge?

arch1t3cht commented 11 months ago

I'm very hesitant about merging PRs updating translations to languages I don't speak, since I can't check myself if they are correct. They're also a bit out of scope for this fork, which mostly collects bugfixes and new features - translation updates would fit better in a more central place like upstream.

I don't mind this PR being open here - that way people can use it for whatever they might need it for - but for now I can't really merge it, sorry.

Hackjjang commented 11 months ago

I think it would be better to merge it and get some feedback. I've been doing Korean localisation for PCSX2, DuckStation, Cemu, etc. I've also done subtitling in the past, and I've been getting feedback on my translations through my blog (although I've only gotten feedback once...).

Hackjjang commented 11 months ago

If the reason is that the existing translation has a lot of mistranslations and untranslated parts, and you can't check the translation problem, it's better to delete it except for the languages you can manage.

Hackjjang commented 10 months ago

I wouldn't have translated it if I didn't think it would be reflected like this... I've done something wrong...

Hackjjang commented 9 months ago

Why not approve it first and see what users think?