みんなの世界

[Ristellise]

...

[TheOneric]

A bit besides the topic (sorry for that), but since you started to reädd (some?) v4++ functionality to Aegisub, does that mean you have any actual v4++ releases? If you do, I'd be very interested in taking a look at them and knowing where and when they came from.

(More on-topic: v4++ also includes a new [V4++ Styles] section name and requires changes to Dialogue and Style parsing, but I guess that's why this is a WIP PR.)

[Ristellise]

A bit besides the topic (sorry for that), but since you started to reädd (some?) v4++ functionality to Aegisub, does that mean you have any actual v4++ releases? If you do, I'd be very interested in taking a look at them and knowing where and when they came from.

(More on-topic: v4++ also includes a new [V4++ Styles] section name and requires changes to Dialogue and Style parsing, but I guess that's why this is a WIP PR.)

Hi! I actually don't have any V4++ releases. So anything now is setting ground work in preparation for v4++.

The plan is to add v4++ support and set v4.00++ as default to shift people to v4.00++ with v4.00+ as a fallback option.

[Ristellise]

I'm going to push a commit which adds untested support for margins. \kt was really easy hook in since it has existing templates.

On the other hand margins are kinda pain to add. But I think I covered most cases. The behavior flow should look like this:

• If the script read is + version & Aegisub is ++ version:
  • copy top margin to bottom margin, enable top margin
• If script read is ++ version, Aegisub is in ++ version:
  • Use Bottom margin and top margin like usual.
• If script read is ++ version, & Aegisub is in + version:
  • Margins are merged and top margins are disabled. When saving only the bottom (Vertical) margins are saved.
• If script read is + version, & Aegisub is in + version:
  • Use Vertical margin. Copy vertical margin to bottom margin for compat with lua scripts. (Lua script should still be able to modify the bottom margin but when saving it out, the bottom margin gets discarded.)

Please let me know if something breaks or like weird behavior. FYI I haven't updated libass version yet. So no ABI changes for now...

[Ristellise]

Essentially abandoned. if anyone wants to pick up the mantle, feel free.