arch1t3cht / Aegisub

Cross-platform advanced subtitle editor, with new feature branches. Read the README on the feature branch.
http://www.aegisub.org
Other
755 stars 34 forks source link

Fix VSScript DLL loading #97

Closed Setsugennoao closed 11 months ago

Setsugennoao commented 11 months ago

We do this by first trying to fetch its location from the registry, then PATH.

This issue is reproducible when vsscript is not in PATH or PATH is not accessible. One use-case is with opening the program via everything on Windows 11 23H2 without admin priviledges.

It's also good practice in general to refer to the install registry keys.

arch1t3cht commented 11 months ago

Merged in https://github.com/arch1t3cht/Aegisub/commit/568597bddc205378de7b5f37ce2c4c15c8d397f3 and https://github.com/arch1t3cht/Aegisub/commit/fd753c58a54386a5edcf9160a18d91f6142f921c