architect-team / architect-cli

Command line interface for running Architect services locally
https://docs.architect.io
38 stars 13 forks source link

Prevent liveness probes causing dev to think something is healthy immediately #852

Closed TylerAldrich closed 1 year ago

TylerAldrich commented 1 year ago

https://gitlab.com/architect-io/architect-cli/-/issues/630

The serverStatus object has a key with the service IP/port and a status like 'UP'. When there's a liveness probe and it's failing, it looks like this:

  serverStatus: { '': 'UP' },

so we incorrectly said it was healthy just because UP existed. But, UP exists because we tell traefik allowEmptyServices now.

Once the service has URL:

  serverStatus: { 'http://172.18.0.2:8080': 'UP' },

the liveness probe actually passed and we can now say it's healthy and open links in the browser.

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 1.35.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: