search

architect-team / architect-cli

Command line interface for running Architect services locally
https://docs.architect.io
38 stars 13 forks source link

Add checks for kubectl and server connection #870

Closed mueschm closed 1 year ago

mueschm commented 1 year ago

Overview

We now make sure that we can reach a cluster before we attempt to register it. We also make sure that the user has kubectl installed and provide better support if we do not.

Changes

  1. We were checking the wrong version when using kubectl. It was grabbing the client version and not the server version.
  2. Using the same version check we now make sure a cluster is reachable before moving forward.
  3. Added a requiresKubectl function to make sure it is installed. Long term we should use the Plugin system for this, but now at least we provide the user with more information than before.

Tests

  1. All tests run
  2. Tested on machine without kubectl installed
  3. Tested on an unreachable cluster
  4. Tested with kubectl installed and a reachable cluster

Pictures

WindowsTerminal_tRau1wOshV WindowsTerminal_j3M2rhM19F
github-actions[bot] commented 1 year ago

:tada: This PR is included in version 1.36.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: