search

architect-team / architect-cli

Command line interface for running Architect services locally
https://docs.architect.io
37 stars 13 forks source link

Use a list of restricted ports instead of allowing ports > 1023. #908

Closed TylerAldrich closed 1 year ago

TylerAldrich commented 1 year ago

Related to the issue here: https://gitlab.com/architect-io/architect-cli/-/issues/662 and an update of https://github.com/architect-team/architect-cli/pull/895.

Restricting ports to 80, 443, and > 1023 wasn't quite doing what we wanted because there's still restricted ports above 1024 (like 6000, which TJ ran into when randomly choosing a port).

Instead of limiting ports based on range, instead use Chrome/FF's restricted port list and don't allow those specifically.

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 1.41.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: