Replace Code Climate with GitHub action for shellcheck

archlinux-downgrade / downgrade

Downgrade packages in Arch Linux

GNU General Public License v2.0

570 stars 24 forks source link

Replace Code Climate with GitHub action for shellcheck #178

Closed atreyasha closed 2 years ago

atreyasha commented 2 years ago

Checklist

[x] No duplicate issues/PRs
[x] Update usage function
[x] Update unit tests
[x] Update shell completions
[x] Update mandoc
[x] Update readme
[x] Update locales
[x] Update change log, if releasing
[x] Update DOWNGRADE_VERSION, if releasing

Description

Remove .codeclimate.yml since we no longer use Code Climate for our checks.

atreyasha commented 2 years ago

Ah I see. I updated our GitHub Actions with shellcheck.yml from here.

atreyasha commented 2 years ago

@pbrisbin is the current configuration alright? Or would it be better if I added the shellcheck job into ci.yml itself?

pbrisbin commented 2 years ago

Good question. I'm not actually sure if there's a meaningful trade-off between distinct Workflows or multiple Jobs. I'm typically add Jobs, but I'm down to try a separate Workflow.

Do you mind naming it lint.yml / name: Lint? Just in case we ever grow into other "lint" activities.

atreyasha commented 2 years ago

Good question. I'm not actually sure if there's a meaningful trade-off between distinct Workflows or multiple Jobs. I'm typically add Jobs, but I'm down to try a separate Workflow.

I don't have much experience with GitHub Actions, so will defer to your opinion on this.

Do you mind naming it lint.yml / name: Lint? Just in case we ever grow into other "lint" activities.

Done