Closed lilydjwg closed 1 year ago
The only thing I can think of is if we'd want to extend this functionality, for example to allow adding to ignore without prompting. --no-prompt-ignore
makes sense to me as "don't prompt to ignore" but it could also be interpreted as "just ignore without prompting". So I wonder if we'd rather have something like --ignore=never|always|prompt
with --ignore=prompt
being the default.
WDYT?
Thanks @lilydjwg for starting the PR!
Agree with @pbrisbin, makes sense to be explicit and have these three possibilities.
I've changed it to be --ignore never|always|prompt
, with a space instead of an equal sign because the option parser doesn't support =
.
Tried some high-level tests of a4fa3675df84ca58da5d417d224616c9e5d1a873 and it works fine. I would say we are good to proceed with next steps in the checklist, which I would be glad to help with.
WDYT?
Hi, I ended up doing more than adding the options: the zsh completion and zh_CN translations have been updated too. I can make them separate pull requests if you prefer.
I can rebase the commits if you want.
closes #210
Checklist
DOWNGRADE_VERSION
Description
What do you think about this? Or a better option name?
I'd like to have the maintainers' options before finishing the checklist.