search

ardumont / org2jekyll

Blogging with org-mode and jekyll without alien yaml headers.
GNU General Public License v2.0
71 stars 19 forks source link

Allows for the usage of new front matter variables - rebased + refactor #41

Closed halcyon closed 8 years ago

halcyon commented 8 years ago

Rebased version of PR #40, which addresses issues #35 and #36.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.2%) to 84.141% when pulling 5fb05aa2317ebf89829b9727e0ca61a6dcdd7aa4 on halcyon:rebased-refactor into 35e11ffa24b140d2e247df195489fca344bd0c08 on ardumont:master.

ardumont commented 8 years ago

Hello again,

One note, you could have forced push on the #40 PR.

This seems good thanks.

One question to make sure i understood right. To add some extra yaml, how one should go along?

For example, to add this:

scheme-text: "#0029ff"
scheme-link: "#ff00b4"

I just add in the org file:

#+scheme-text: "#0029ff"
#+scheme-link: "#ff00b4"

And when exported, we'll have the expected yaml. Did i understand right?

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.2%) to 84.141% when pulling d1fc4f7e4477921c8bc10ee51c57748c490c2163 on halcyon:rebased-refactor into 35e11ffa24b140d2e247df195489fca344bd0c08 on ardumont:master.

halcyon commented 8 years ago

I felt hesitant to force push to PR #40 because I ended up creating a new branch and manually reimplementing the original PR instead of using interactive rebase - it was too much of a mess! I wasn't thrilled about creating a new PR, but I didn't want to risk obfuscating the original PR and discussion. Will definitely keep force push on hand for future work.

Yes, your interpretation is correct. Although the convention for Org mode's special lines seems to be all caps. The PR downcases as part of the transformation, so the result should be the same and less jarring with:

Input:

#+SCHEME-TEXT: "#0029ff"
#+SCHEME-LINK: "#ff00b4"

Output:

scheme-text: "#0029ff"
scheme-link: "#ff00b4"
coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.2%) to 84.141% when pulling b4d5ba00df61669c639d6d53d2798829c3059908 on halcyon:rebased-refactor into 35e11ffa24b140d2e247df195489fca344bd0c08 on ardumont:master.

ardumont commented 8 years ago

Yes, your interpretation is correct. Although the convention for Org mode's special lines seems to be all caps. The PR downcases as part of the transformation, so the result should be the same and less jarring with:

Yes, indeed. It is my experience org's ok with lower case as well. In any case, thanks a bunch.

I'll adapt the README.org

Cheers,