ardumont / org2jekyll

Blogging with org-mode and jekyll without alien yaml headers.
GNU General Public License v2.0
71 stars 19 forks source link

Dummy tags persisting even with tags:nil #58

Closed andyqhan closed 4 years ago

andyqhan commented 4 years ago

Hi, The HTML file that org2jekyll outputs contains the "dummy-tags-should-be-removed" thing, even though I have set tags:nil. My full options line is #+OPTIONS: tags:nil toc:nil timestamps:t. I'm probably just not doing something right. The relevant HTML section:

---
tags: 
- 
- 
- 
- 
- 
- 
- dummy-tags-should-be-replaced
---

Thanks!

ardumont commented 4 years ago

Hello, looks like a bug alright. Thanks for the report.

I'll have a look to see if I see anything strikingly wrong on org2jekyll's side ;)

In the mean time, if you have the latest version, could you please report the output of M-x org2jekyll-bug-report?

Thanks

ardumont commented 4 years ago

Without any code reading already, just reflecting.

The first thing that hits me is that I don't recall the meaning of org-mode's "tags" (in the main header) [1]. So most possibly, it's the root source of the problem ¯_(ツ)_/¯.

org2jekyll simply acts on the #+TAGS entry whether tags is configured to something or not. So that needs enhancement to respect the user's buffer setup.

(added the label enhancement)

Reading again the orgmode page, the #+TAGS property should be a list of words separated by space. In org2jekyll, it's expected to be comma separated values (csv)... So another improvment incoming for that part as well.

[1] https://orgmode.org/manual/Setting-Tags.html

Cheers,

ardumont commented 4 years ago

Following analysis from your report, i faced some inconsistencies.

I have fixed those including respecting the user setup. A new version 0.2.1 got released.

Please, upgrade and check the problem mentioned no longer appears ;)

Cheers,

andyqhan commented 4 years ago

It's working perfectly now. Je vous remercie beaucoup pour votre réponse super vite!

ardumont commented 4 years ago

Awesome, thanks for the heads up.