search

arfc / publications

public repository for the development and distribution of publications
Creative Commons Attribution 4.0 International
2 stars 7 forks source link

Address final reviewer comments. #66

Closed lindsayad closed 6 years ago

lindsayad commented 6 years ago

You should probably view this PR ignoring whitespace. (I actually forget how to do this with GitHub)

If I can do it quickly enough, I actually want to re-generate the plots on a finer mesh since IMO the coarse mesh plots are not sufficiently converged (despite what I say currently).

gridley commented 6 years ago

I'll add it in a bit, but it may be noteworthy that Dr. Collins is working on putting a 3D cuboidal MSRE into MSR-VERA. When compared with their detailed sub-channel TH models and full-core 152 group MOC neutronics, we should be able to approximate the error introduced by introducing diffusion neutronics and slug flow.

lindsayad commented 6 years ago

What do you mean by a bit? It's due today haha

gridley commented 6 years ago

Haha, sorry, well, he told me initially that it would take him a matter of hours to put the geometry into VERA. Apparently there have been some complications. So, I think making a note of this next to the openFOAM remark would be good.

gridley commented 6 years ago

what do you think of the additional remark @lindsayad?

katyhuff commented 6 years ago

ignore whitespace with ?w=1

katyhuff commented 6 years ago

LGTM