search

arfc / publications

public repository for the development and distribution of publications
Creative Commons Attribution 4.0 International
2 stars 7 forks source link

2017 bae europe #7

Closed jbae11 closed 7 years ago

jbae11 commented 7 years ago

@katyhuff

I think it is ready for review. Thanks for your patience!

jbae11 commented 7 years ago

@katyhuff I have reflected the comments and updated the paper for some clarity!

Thanks

katyhuff commented 7 years ago

Thanks for your work here. I'm going to merge this because the review is getting too long and you've definitely addressed most of my concerns. Good work.

That said, I do see a few new things that have cropped up among the fixes (et al continues to be missing punctuation, questions still remain about the need for separate simulations, etc.) So, I'm going to do a re-review and create new issues for each of the remaining issues I see (in the hopes that the fixes will appear in single atomic pull requests rather than these large all-encompasing ones.)

Also, I did ask a number of questions during my review. In the future, it would be great if those questions were answered in actual responses in the github interface in addition to changes in the text. In some cases I really did want to know the answer and it's somewhat cumbersome to tease out the answer when it is addressed only in the text (I have to click back and forth between my review, the old text, and the new text, to figure out what your reaction to the question was.)

Anyway, good work, new issues incoming.