search

arfc / publications

public repository for the development and distribution of publications
Creative Commons Attribution 4.0 International
2 stars 7 forks source link

Bae europe minor #75

Closed katyhuff closed 6 years ago

katyhuff commented 6 years ago

This PR handles most of the concerns in this pdf: europe_nuclear_paper.pdf

A few edits remain, namely this work needs more discussion regarding the figures displaying the results. However, this may be ready for review by Prof. Singer.

jbae11 commented 6 years ago

@katyhuff Thank you so much for taking your time doing this. I think we should show this to professor Singer after updating the zenodo citation (pr at transition-scenarios in progress)

katyhuff commented 6 years ago

@jbae11 : what is the status of your review?

jbae11 commented 6 years ago

Looks good! I think the only thing is the zenodo update! Thanks! Is it customary for the reviewer to merge the pr?

katyhuff commented 6 years ago

Yes, it's customary for the reviewer to merge the pr. Regarding the zenodo update I think that's a separate matter. Is it not?

On Fri, Feb 9, 2018, 12:59 PM Jin Whan Bae notifications@github.com wrote:

Looks good! I think the only thing is the zenodo update! Thanks! Is it customary for the reviewer to merge the pr?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/arfc/publications/pull/75#issuecomment-364509828, or mute the thread https://github.com/notifications/unsubscribe-auth/AAYCq_wuguC_cZr_cFrVD1Krd1NJqxnfks5tTId2gaJpZM4RxrBW .

jbae11 commented 6 years ago

Yup! Should I print it and show it to Dr.Singer?

katyhuff commented 6 years ago

Thanks! Yeah, I think you can send it to prof singer now. (Either email or let, however he prefers it.)

Thanks! On Fri, Feb 9, 2018 at 2:53 PM Jin Whan Bae notifications@github.com wrote:

Merged #75 https://github.com/arfc/publications/pull/75.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/arfc/publications/pull/75#event-1467390810, or mute the thread https://github.com/notifications/unsubscribe-auth/AAYCq8vgZxOkLRpepV3Pu7TsCLZPyX3cks5tTKIggaJpZM4RxrBW .

katyhuff commented 6 years ago

Let =pdf (autocorrect typo) On Fri, Feb 9, 2018 at 4:47 PM Katy Huff katyhuff@gmail.com wrote:

Thanks! Yeah, I think you can send it to prof singer now. (Either email or let, however he prefers it.)

Thanks! On Fri, Feb 9, 2018 at 2:53 PM Jin Whan Bae notifications@github.com wrote:

Merged #75 https://github.com/arfc/publications/pull/75.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/arfc/publications/pull/75#event-1467390810, or mute the thread https://github.com/notifications/unsubscribe-auth/AAYCq8vgZxOkLRpepV3Pu7TsCLZPyX3cks5tTKIggaJpZM4RxrBW .