arichornlover / uYouEnhanced

uYouEnhanced (by @arichornlover) is an expanded version of uYou+ (made by @qnblackcat) with additional features and mainly made for non jailbroken users!
https://github.com/arichornlover/YouTubeRebornPlus/
2.32k stars 3.55k forks source link

Request: Timestamp copy button #401

Closed KarmaBeast closed 5 months ago

KarmaBeast commented 8 months ago

Would be very useful if we had this button from Revanced Extended:

Screenshot_20240228-092949694 (1).jpg

KarmaBeast commented 8 months ago

Is that something you could implement? @arichornlover

arichornlover commented 8 months ago

The problem is how did Revanced implement this? You know uYouEnhanced is iOS, not Android, but I do hope it’s possible to implement this.

KarmaBeast commented 8 months ago

I used this feature so often with my Android. Every day sharing videos to my friends and copying the timestamp of the exact point I want them to see in the video. So when they open the link the video starts exactly there.

It's so damn useful to have.

arichornlover commented 8 months ago

Would be very useful if we had this button from Revanced Extended:

Screenshot_20240228-092949694 (1).jpg

https://github.com/arichornlover/YouTimeStamp/commit/86f8e0159fe302e3f45c97831d38d84a0dba1883 I couldn’t find the icon that ReVanced used in the screenshot above, also made a new repository, however don’t be excited yet. Nothing has been made in there. There is no functionality to copy the timestamp yet.

KarmaBeast commented 8 months ago

Ok understood. Thanks for keeping me posted. Having this feature would be awesome!

KarmaBeast commented 7 months ago

@arichornlover could you please consider prioritizing this request?

None of my iOS shortcuts are working anymore when I switched over to non-official YouTube (enhanced)

None of these work: image

KarmaBeast commented 7 months ago

I already spent so much time trying the iOS shortcuts with enhanced, but they simply don't work anymore.

It appears they only work with AppStore YouTube...

bhackel commented 7 months ago

@arichornlover how is progress on this tweak going?

arichornlover commented 7 months ago

Not very far, the last time I did progress was last week. https://github.com/arichornlover/YouTimeStamp/tree/wip, https://github.com/arichornlover/uYouEnhanced/actions/runs/8320563008 I’ve been looking around in YouTube ReVanced’s I did replicate some things using Obj-C but so far compiling the ipa successfully with this Tweak won’t work yet. Which is expected. Also this is what I’m referring to with whatever I’m doing: https://github.com/ReVanced/revanced-integrations/blob/07482094a35793797770c8238fc5554395994ae8/app/src/main/java/app/revanced/integrations/youtube/patches/CopyVideoUrlPatch.java#L35

KarmaBeast commented 7 months ago

Any good news on this? 🙏🏻

arichornlover commented 7 months ago

Well no. However, the button seems to be showing but it doesn’t work if pressed, I gotta find a way for that to work.

aaronliu0130 commented 6 months ago

@KarmaBeast At least https://www.icloud.com/shortcuts/7ecdbce4df394880954cda3b6de5702b works with me

KarmaBeast commented 6 months ago

I believe arichorn will soon implement this idea into uYouEnhanced 🙏🏻

aaronliu0130 commented 6 months ago

Yeah, but in the meantime you should be able to summon the shortcut from the iOS share dialog

arichornlover commented 6 months ago

I am now modifying the tweak YouTimeStamp.

branch called YouTimeStamp has been pushed and updated to the most recent commit from Main.

arichornlover commented 6 months ago

Here’s a presentation of the new YouTimeStamp Icon and options! IMG_1717 IMG_1716

aaronliu0130 commented 6 months ago

Uhh, which one is it? The speedy clock seems like it adjusts the playback speed.

arichornlover commented 6 months ago

Uhh, which one is it? The speedy clock seems like it adjusts the playback speed.

I didn’t have the actual icon that resembles the “copying the Timestamp”, for now the speedy clock icon is a placeholder I guess?

aaronliu0130 commented 6 months ago

The copy icon seems to be the copy icon (which hopefully one can find somewhere in YouTube like the share button or in FontAwesome if they're desperate) combined with a clock in the bottom right.

A more complicated implementation would be to also add this in the share dialog.

arichornlover commented 6 months ago

A more complicated implementation would be to also add this in the share dialog.

I think the Share Dialog would be close to impossible since Google made this menu Server-Side ☹️ IMG_2773

aaronliu0130 commented 6 months ago

Stretch goal here: tweak to skip straight to the native one? :p

Anyways just the button form would be nice!

arichornlover commented 6 months ago

The copy icon seems to be the copy icon (which hopefully one can find somewhere in YouTube like the share button or in FontAwesome if they're desperate) combined with a clock in the bottom right.

A more complicated implementation would be to also add this in the share dialog.

Timestamp@3

KarmaBeast commented 6 months ago

I think the icon from Revanced in the first post looks nice. Maybe use that?

KarmaBeast commented 6 months ago

Here’s a presentation of the new YouTimeStamp Icon and options!

IMG_1717

IMG_1716

It looks awesome. Btw I noticed something. How did you manage to bring down the quality and mute button to the bottom again, and have both visible? This was broken a while ago, and I'm forced to keep the qualify button at the top now....

aaronliu0130 commented 6 months ago

I usually associate the menu icon with menus or right click. How about https://fonts.google.com/icons?selected=Material+Symbols+Sharp:content_copy:FILL@0;wght@400;GRAD@0;opsz@24&icon.query=copy&icon.style=Sharp + the clock?

Edit: my deleted comment quoted archorn saying they couldn't find the icon ReVanced used in response to Karma.

KarmaBeast commented 6 months ago

Screenshot_20240228-092949694 (1).jpg

That's essentially the same as this one from Revanced

arichornlover commented 6 months ago

The copy icon seems to be the copy icon (which hopefully one can find somewhere in YouTube like the share button or in FontAwesome if they're desperate) combined with a clock in the bottom right. A more complicated implementation would be to also add this in the share dialog.

Timestamp@3

I have an icon here? very similar I guess but It is hard to see since it is set with the color Black.

KarmaBeast commented 6 months ago

That icon looks bad and weird imo. The one Aronliu shared combined with a clock looks closest to the Revanced icon.

aaronliu0130 commented 6 months ago

Like I said, it doesn't tell "copy" to me.

arichornlover commented 6 months ago

That icon looks bad and weird imo. The one Aronliu shared combined with a clock looks closest to the Revanced icon.

I might aswell try recreating the Revanced version using the copy icon from aaronliu0130

KarmaBeast commented 6 months ago

Looks like a paper and a very small clock. Nothing that would make you think is a copy timestamp button.

arichornlover commented 6 months ago

content_copy_FILL0_wght400_GRAD0 I just now recreated the Icon using what I had. What do you think?

KarmaBeast commented 6 months ago

content_copy_FILL0_wght400_GRAD0

I just now recreated the Icon using what I had. What do you think?

I think it looks nice, but the clock is too small? Make it a little bigger?

arichornlover commented 6 months ago

content_copy_FILL0_wght400_GRAD0 how about now?

KarmaBeast commented 6 months ago

Looks pretty good I'd say.

Btw arichorn when are you finally gonna join us on the telegram group uYouEnhanced? Let's discuss things there. Bhackel is also there. We are at 465 members now. Please consider installing the telegram app and joining us! 🙏🏻

https://t.me/uYouEnhanced

arichornlover commented 6 months ago

Here’s what the new icon looks like in the app. I forgot to send this. IMG_1725

KarmaBeast commented 6 months ago

It looks solid imo. Very well done! 👌🏻

(Unfortunately my signing service doesn't let me install new ipas at the moment so I won't be able to test/use it. Hopefully it'll work before you implement it.)

arichornlover commented 6 months ago

It looks solid imo. Very well done! 👌🏻

(Unfortunately my signing service doesn't let me install new ipas at the moment so I won't be able to test/use it. Hopefully it'll work before you implement it.)

Don’t test the new IPAs, I didn’t implement the button in the Main branch (except for the icon, it exists in it)

However, I do have a branch called YouTimeStamp which has the button implementation (which is unfinished since it doesn’t currently work.)

KarmaBeast commented 6 months ago

Ok got it. Looking forward to the actual implementation ☝🏻

Also can you tell me how you're able to have the quality and mute button both at the bottom again? This isn't working for me anymore and am forced to move the quality button to top...

arichornlover commented 6 months ago

Ok got it. Looking forward to the actual implementation ☝🏻

Also can you tell me how you're able to have the quality and mute button both at the bottom again? This isn't working for me anymore and am forced to move the quality button to top...

the fullscreen button is visible, not hidden, which is why it is workimg fine.

workaround: enable the YouTimeStamp icon at the bottom and it will fix the YouQuality button problem 😁

KarmaBeast commented 6 months ago

the fullscreen button is visible, not hidden, which is why it is workimg fine.

Oh I see. It was working fine without the fullscreen button, but Miro/uyou changed something few weeks ago and it broke went invisible.

workaround: enable the YouTimeStamp icon at the bottom and it will fix the YouQuality button problem 😁

It will? Ok then I will try that when it's out. But it would be nice if these were not dependent on eachother. The fact that when hiding the fullscreen button the quality button at the bottom goes invisible is really annoying 😐

I don't like the fullscreen button and don't need it, since I use swipe gestures to enter/exit fullscreen.

arichornlover commented 6 months ago

I might downgrade the YouQuality tweak. The workaround stopped working whenever I restarted the app ;(

KarmaBeast commented 6 months ago

:sadkarma:😓

I have no freakin clue why Miro updated uYou for no apparent reason ... Tweaks are still broken and now this aswell...

aaronliu0130 commented 6 months ago

Veering into off-topic areas here, but...

3.0.3

  • Fixed startup crash.
  • Fixed minor UI issues.
  • Added "Hide Next/Previous Buttons".
  • Added "Disable Double Tap To Seek".
  • Added "Disable Startup To Shorts".
  • Resolved issue where downloaded video/audio files were not being deleted properly.
KarmaBeast commented 6 months ago

3.0.3

  • Fixed minor UI issues.

There were no UI issues. He made the font of the buttons tiny and barely readable. Also when hiding the fullscreen button, the Quality button becomes invisible at bottom/cannot be used at bottom anymore... Don't fix what it isn't broken.

  • Added "Hide Next/Previous Buttons".

Doesn't work in playlists.

  • Added "Disable Double Tap To Seek".

No idea how disabling that is useful. Double tapping to seek is a useful feature to navigate thru videos.

  • Resolved issue where downloaded video/audio files were not being deleted properly.

Downloading videos doesn't work for most users anyway.

// There are still several uYou tweaks which simply don't work/are broken. I wish he could address those some time in the future. But anyway this too offtopic. Let's stick to Copy timestamp again.

arichornlover commented 6 months ago

There are still several uYou tweaks which simply don't work/are broken.

I got a reasonable explanation for this: Google updates the YouTube App. and usually when they do, it can break things like uYou.

KarmaBeast commented 6 months ago

Bhackel said it. If he didn't make uYou closed source it would be easier to fix those broken tweaks.

arichornlover commented 6 months ago

Bhackel said it. If he didn't make uYou closed source it would be easier to fix those broken tweaks.

That is also true. I do wish MiRO92 open-sourced uYou.

the shocking part is that YouTube Reborn literally downloads video and audio faster, no offense.

KarmaBeast commented 5 months ago

How's progress on this feature going? 👋🏻

arichornlover commented 5 months ago

It’s been a wreck. It’s failing to find the videoID url. I might have to give it FFMPEG stuff soon.