arichornlover / uYouEnhanced

uYouEnhanced (by @arichornlover) is an expanded version of uYou+ (made by @qnblackcat) with additional features and mainly made for non jailbroken users!
https://github.com/arichornlover/YouTubeRebornPlus/
2.32k stars 3.55k forks source link

Request: Timestamp copy button #401

Closed KarmaBeast closed 5 months ago

KarmaBeast commented 8 months ago

Would be very useful if we had this button from Revanced Extended:

Screenshot_20240228-092949694 (1).jpg

KarmaBeast commented 5 months ago

Idk what the hell FFMPG stuff is, but perhaps could we ask the Revanced repo/devs?

arichornlover commented 5 months ago

Idk what the hell FFMPG stuff is, but perhaps could we ask the Revanced repo/devs?

I am probably just not good at porting things like for example functionality from Revanced. I am trying.

bhackel commented 5 months ago

@arichornlover What is the current issue? I have worked with timestamp stuff before in a few tweaks, maybe I can take a look

arichornlover commented 5 months ago

https://github.com/arichornlover/YouTimeStamp/blob/wip/Tweak.x Here it is. I was trying to use the Headers from YouTubeHeader, I’m probably off track with it.

bhackel commented 5 months ago

@arichornlover It looks like it works on the top but crashes when on the bottom. This is the error: exceptionReason" : {"arguments":["%s","playerViewController","0x10fd44ea0"],"format_string":"-[%s %s]: unrecognized selector sent to instance %p","name":"NSInvalidArgumentException","type":"objc-exception","composed_message":"-[%s playerViewController]: unrecognized selector sent to instance 0x10fd44ea0","class":"NSException"},

arichornlover commented 5 months ago

Closed since the button is ready to be added next release, thanks to bhackel for helping!

KarmaBeast commented 5 months ago

Closed since the button is ready to be added next release, thanks to bhackel for helping!

Thanks to both of you for fulfilling this request!! ❤️

One last question; Will it work at the bottom aswell right? That's where I would place it

arichornlover commented 5 months ago

One last question; Will it work at the bottom aswell right? That's where I would place it

It will work at the bottom just like the button at the top, bhackel has found a method to make it work without crashing!

KarmaBeast commented 5 months ago

There have been some very bad news today regarding Sponsorblock etc.

image

image

Im wondering in the case this test gets widely rolled out, will it affect timestamped video links? Will this feature still work properly, or no? (Because some people are claiming timestamped links won't be working anymore)

arichornlover commented 5 months ago

There have been some very bad news today regarding Sponsorblock etc.

Im wondering in the case this test gets widely rolled out, will it affect timestamped video links? Will this feature still work properly, or no? (Because some people are claiming timestamped links won't be working anymore)

Thanks for telling me about this. If this ever gets rolled out on YouTube then it would make the YouTimeStamp tweak or any of the ones from ReVanced end up making all the timestamps offset due to the ad times.

aaronliu0130 commented 5 months ago

It'll make every timestamped link invalid, so I doubt that we should worry about this.

KarmaBeast commented 5 months ago

Also please Read these news:

https://gist.github.com/ajayyy/f7b1807e13731c25cef4c2c057d022bc

arichornlover commented 5 months ago

Also please Read these news:

https://gist.github.com/ajayyy/f7b1807e13731c25cef4c2c057d022bc

So right now it’s using client-side (aka A/B) flags. If this “Client-Side Ad Injection” starts happening on uYouEnhanced then share me y’all’s A/B flags whenever it happens. Because I can probably reverse those experimental changes by turning them off until it eventually stops working in the future.

KarmaBeast commented 4 months ago

https://youtu.be/weP62wPEjRw?si=QMYBUz5RvpIU5Hfb

Louis Rossmann has finally spoken about it aswell. Let's hope for all our sakes that they don't follow thru with this BS.