mixed bag of patches - Mk install

[jimc]

heres 4 patches

b1a33c (HEAD -> mk-install, ghlinux/mk-install) configkernel: be more like make O=outdir b9df537 configkernel: config comment cosmetics 261e801 vng-run: get kdir from O= 2e37ad9 add Makefile install target

some issues, mostly minor, maybe some revisions ?

[jimc]

further testing suggests that one of these, or the build-script using it, isnt quite ready

[jimc]

alright, heres a refresh of the 4,

+2 maybe's -

alias --custom to --config - maybe only in run.py
configkernel doesnt really need the alias I gave it

pass-thru --verbose from run to configkernel

[jimc]

hold off yet - somethings not right

In my build-out script, I seem to have replaced one makefile error for another

[jimc@frodo builds]$ bo_plant_x
doing: vng -vb O=./builds/bx-defcon
cmd: virtme-configkernel --defconfig --verbose --no-update O=./builds/bx-defcon 
custom:
[]
make: *** No rule to make target 'x86_64_defconfig'.  Stop.
missing Makefile, adding -f $src/Makefiledoing: vng -vb O=./builds/bx-dd --custom /home/jimc/projects/lx/kfrag.dyndbg
cmd: virtme-configkernel --defconfig --verbose --no-update --custom /home/jimc/projects/lx/kfrag.dyndbg O=./builds/bx-dd 
custom:
['\n', 'CONFIG_LOCALVERSION_AUTO=y\n', 'CONFIG_LOCALVERSION="-dd"\n', '\n', 'CONFIG_DYNAMIC_DEBUG=y\n', 'CONFIG_DYNAMIC_DEBUG_CORE=y\n', 'CONFIG_TEST_DYNAMIC_DEBUG=m\n', 'CONFIG_TEST_DYNAMIC_DEBUG_SUBMOD=m\n', '\n']
make: *** No rule to make target 'x86_64_defconfig'.  Stop.
missing Makefile, adding -f $src/Makefiledoing: vng -vb O=./builds/bx-dd-drm --custom /home/jimc/projects/lx/kfrag.dyndbg --custom /home/jimc/projects/lx/kfrag.drm-min
cmd: virtme-configkernel --defconfig --verbose --no-update --custom /home/jimc/projects/lx/kfrag.dyndbg --custom /home/jimc/projects/lx/kfrag.drm-min O=./builds/bx-dd-drm 
custom:
['\n', 'CONFIG_LOCALVERSION_AUTO=y\n', 'CONFIG_LOCALVERSION="-dd"\n', '\n', 'CONFIG_DYNAMIC_DEBUG=y\n', 'CONFIG_DYNAMIC_DEBUG_CORE=y\n', 'CONFIG_TEST_DYNAMIC_DEBUG=m\n', 'CONFIG_TEST_DYNAMIC_DEBUG_SUBMOD=m\n', '\n', '\n', 'CONFIG_DRM_USE_DYNAMIC_DEBUG=y\n', 'CONFIG_DRM=m\n', '\n', 'CONFIG_DRM_AMDGPU=m\n', 'CONFIG_DRM_NOUVEAU=m\n', 'CONFIG_DRM_AMDGPU=m\n', 'CONFIG_DRM_I915=m\n', 'CONFIG_DRM_XE=m\n']
make: *** No rule to make target 'x86_64_defconfig'.  Stop.

it might be as simple as the --no-update, but it will take some research

and one of my patches needs a \n

[jimc]

thanks for picking up the makefile bits in #142, The other bits need more bake-time I think. I'll work them further...

[arighi]

@jimc I was going to start reviewing this, but noticed that you closed it. :)

Let me know if you need help with this and I can take a look if you want. Thanks!

[jimc]

On Sun, Jul 28, 2024 at 12:58 AM Andrea Righi @.***> wrote:

@jimc https://github.com/jimc I was going to start reviewing this, but noticed that you closed it. :)

ICBW, but I think you merged most of the pieces in #142 and I was gonna retest the O=outdir related bits some more. IIRC, the O=outdir handling works from/in configkernel, but not quite right for vng

Let me know if you need help with this and I can take a look if you want. Thanks!

— Reply to this email directly, view it on GitHub https://github.com/arighi/virtme-ng/pull/130#issuecomment-2254367801, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAUBQ6RJCHOFNWVYEG3EFLZOSJABAVCNFSM6AAAAABJYQN5JOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJUGM3DOOBQGE . You are receiving this because you were mentioned.Message ID: @.***>