search

arighi / virtme-ng

Quickly build and run kernels inside a virtualized snapshot of your live system
GNU General Public License v2.0
350 stars 35 forks source link

The PyPI source tarball for 1.27 doesn't require argparse-manpage #146

Closed WOnder93 closed 2 days ago

WOnder93 commented 1 month ago

I don't know why, but the argparse-manpage requirement doesn't seem to have propagated into the PyPI release. The virtme-ng-1.27/virtme_ng.egg-info/requires.txt file in the source tarball only contains argcomplete and requests.

arighi commented 1 month ago

@WOnder93 good catch! It should be fixed by #149. Do you think we should cut another version?

WOnder93 commented 1 month ago

No need to do that for me - I ran into it when packaging for Fedora, but there the argparse-manpage binary is in a separate package from the Python library ( :shrug: ), so the automatic dependency generation doesn't pull it and I had to add an explicit build dependency anyway.

BTW, you have a typo in the commit title (".txg").

arighi commented 1 month ago

Commit title fixed (thanks again!). I may have to apply other fixes/changes soon, so let's wait a bit before cutting a new version, the missing dependency shouldn't cause much troubles (hopefully).

WOnder93 commented 2 days ago

Closing, as this is already fixed by #149.