arioch / puppet-ulimit

Puppet module to manage Ulimit on Linux hosts
Other
11 stars 29 forks source link

Using purge on limit.d direcoty is a bit dangerous. #1

Closed Oded-B closed 11 years ago

Oded-B commented 12 years ago

In the class ulimit::config you use "purge => true;" . letting puppet remove all files is that dir is a bit dangerous as some packages place files in that direcoty. As a system administrator you are not always aware of the these files so maintaining this directory solely by puppet is not always possible.

arioch commented 12 years ago

You certainly do have a valid point there. However it all depends on the use case, internal guidelines and politics whether or not to have it purged.

The customer it was written for at the time wanted to have full control over what happened during deploy. I could write some functionality around it to make it configurable...

Oded-B commented 12 years ago

I think that documenting this behavior in README.md could be enough - my real issue is that it caught me by surprise ;) People can disable it pretty easily.

Anyways , thanks for the mod' - I find useful.

arioch commented 11 years ago

Hm seems I've missed a noticiation about your last reply. This is now configurable and documented. Better late than never I guess.