armin-reichert / pacman-javafx

Cloning the classic games Pac-Man (Arcade), Ms. Pac-Man (Arcade), Ms. Pac-Man (Tengen) in JavaFX (2D+3D).
MIT License
102 stars 18 forks source link

Refactoring of Implementation and Design smells #9

Closed HarshMaisuri closed 7 months ago

armin-reichert commented 7 months ago

Hello,

thanks for looking into my code and your proposals. However, I do not accept any pull requests concerning code "quality" or style or conformance to some metrics. Also, some of your proposals like introducing another subclass just to extract some implementation part seems wrong to me. Adding constants for points in time might indeed improve code readability, so I added some of those in some GameState subclasses.

Armin Reichert