Open ghost opened 10 years ago
@abelbeck : This seems ok. Agreed?
The coding looks good. There are extra newlines at the end that could be removed.
In fairness, we don't use this script in AstLinux so I can't test much more than a basic sanity check.
Hello arnova & abelbeck, and thanks for the feedbacks. I have removed the mentioned extra newlines at the end of the file. Regarding Git, I'm sorry for not being able to use it in a more elegant fashion, but I'm still a complete newbie on this platform. Is there a quick way to squash all commits right here on Github?
Yup, do:
You could have done a simular action for the previous pullrequest you created.
Hello Arno
Please put the read on the next line for clarity
Done.
I tried to squash the commits with git, but I couldn't do that, as I made all changes using GitHub's web interface, so I have nothing locally. In fact my question was if it's ever possible to do the squash with GitHub's web interface. I do understand that you prefer to use git for the development of aif, but right now I'm not really motivated to learn it. If you need a one-file-patch in order to merge my changes, then I can send it to you with an old-fashioned e-mail; if you're still interested in them of course. :)
Somehow this PR totally lost my attention, sorry about that. I'm still plan on merging this. It's correct that anything in the PR supersedes PR #9 , right?
Merged previously proposed commits into a single commit. Added a few minor edits.