arno-iptables-firewall / aif

GNU General Public License v2.0
151 stars 24 forks source link

Modified configure.sh (includes all previous commits) #10

Open ghost opened 10 years ago

ghost commented 10 years ago

Merged previously proposed commits into a single commit. Added a few minor edits.

arnova commented 10 years ago

@abelbeck : This seems ok. Agreed?

abelbeck commented 10 years ago

The coding looks good. There are extra newlines at the end that could be removed.

In fairness, we don't use this script in AstLinux so I can't test much more than a basic sanity check.

ghost commented 10 years ago

Hello arnova & abelbeck, and thanks for the feedbacks. I have removed the mentioned extra newlines at the end of the file. Regarding Git, I'm sorry for not being able to use it in a more elegant fashion, but I'm still a complete newbie on this platform. Is there a quick way to squash all commits right here on Github?

arnova commented 10 years ago

Yup, do:

You could have done a simular action for the previous pullrequest you created.

ghost commented 9 years ago

Hello Arno

Please put the read on the next line for clarity

Done.

I tried to squash the commits with git, but I couldn't do that, as I made all changes using GitHub's web interface, so I have nothing locally. In fact my question was if it's ever possible to do the squash with GitHub's web interface. I do understand that you prefer to use git for the development of aif, but right now I'm not really motivated to learn it. If you need a one-file-patch in order to merge my changes, then I can send it to you with an old-fashioned e-mail; if you're still interested in them of course. :)

arnova commented 5 years ago

Somehow this PR totally lost my attention, sorry about that. I'm still plan on merging this. It's correct that anything in the PR supersedes PR #9 , right?