arnonram / swade-npc-importer

Savage Worlds Stat-block importer for FoundryVTT
7 stars 8 forks source link

Untranslated parts in German #106

Closed Razortide closed 2 years ago

Razortide commented 2 years ago

NPC Importer "Main Screen": The selection lists are not imported:

  1. Actors type is NPC, Character not NSC and Charakter
  2. Wild Card is Yes / No instead of Ja / Nein
  3. Disposition is Hostile/Neutral/Friendly instead of Feindlich/Neutral/Freundlich
  4. Vision Radius does not have a translation expression in de.json
  5. Degrees (360 if empty) does not have a translation expression in de.json (btw. there is a typo. It is degress, instead of degrees)

Actor already exists: Import with different name exists in de.json but is not applied.

arnonram commented 2 years ago

English was actually hardcoded in here... so no translation at all..

I've added the following lines to en.json

  "npcImporter.HTML.Yes": "Yes",
  "npcImporter.HTML.No": "No",
  "npcImporter.HTML.VisionRadius": "Vision Radius",
  "npcImporter.HTML.VisionAngleLable": "Degrees (360 if empty)",
arnonram commented 2 years ago

@Razortide i can add to the German with google translate, but i see you already have another pull request ready, so why don't you add them to the de.json file

Razortide commented 2 years ago

Hello @arnonram,

added strings to the PR as suggested.

Best regards, Marc

Razortide commented 2 years ago

Hey @arnonram, I found a few missing strings:

arnonram commented 2 years ago

@Razortide good catch. Thanks

Found another hard-coded one: Save

Razortide commented 2 years ago

Inserted the discussed strings in to de.json. See #109