search

arnonram / swade-npc-importer

Savage Worlds Stat-block importer for FoundryVTT
7 stars 8 forks source link

Failed to build finalActor error #133

Closed ScottSilLew closed 1 week ago

ScottSilLew commented 1 year ago

Hi,

When I try copy and paste a stat block into the text field and click the button to complete it, the window closes and no actor shows up in the expected folder. I looked at the log and it says "Failed to build finalActor: ReferenceError: isEmpty is not defined" on line 29 in global.js.

I'm using this block to test:

Agent Employed by the shadowy Agency, US Agents investigate espionage and supernatural incidents.

Attributes: Agility d8, Smarts d8, Spirit d6, Strength d6, Vigor d6 Skills: Academics d6, Athletics d6, Common Knowledge d6, Fighting d6, Notice d8, Occult d6, Persuasion d6, Research d6, Shooting d8, Stealth d8, Survival d4 Pace: 6; Parry: 5; Toughness: 5 Edges: Agent, Guts, Level Headed, Rock and Roll! Hindrances: Cautious, Vow (Major-Destroy or contain the supernatural) Gear: Gatling pistol (Range 12/24/48, Damage 2d6, RoF 3, AP 1), disguise kit, Agency badge.

arnonram commented 1 year ago

Hi @ScottSilLew ,

I couldn't reproduce it locally,

I learned from chatting with others, that the PDF software used might raise some issue as well...

Are you copying from PDF? If you copy the stat-block from your issue here (meaning, not directly from pdf) and try to import does it still fail?

Also, can you please specify:

ScottSilLew commented 1 year ago

Hi @arnonram,

I'm using: Foundry version 9 build 280. Swade version 1.0.7 Module Version 0.2.0

I'm the game master, so I'm using the local Foundry browser. I think I recall a patch note for Foundry saying that "isEmpty" was deprecated, but I could be wrong. It might have also been that isEmpty replaces something else.

arnonram commented 1 year ago

Hi Scott,

Those are some old versions you got there (foundry & swade), which version 0.2.x do not support.

So sorry 😔

Any reason why you are not updating?

On Sat, Feb 4, 2023, 21:31 ScottSilLew @.***> wrote:

Hi @arnonram https://github.com/arnonram,

I'm using: Foundry version 9 build 280. Swade version 1.2.5 Module Version .2.1

I'm the game master, so I'm using the local Foundry browser. I think I recall a patch note for Foundry saying that "isEmpty" was deprecated, but I could be wrong. It might have also been that isEmpty replaces something else.

— Reply to this email directly, view it on GitHub https://github.com/arnonram/swade-npc-importer/issues/133#issuecomment-1416832426, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKNHYKSCCTU6WBSJQELZ6ALWV2U75ANCNFSM6AAAAAAUPZKUX4 . You are receiving this because you were mentioned.Message ID: @.***>

ScottSilLew commented 1 year ago

Yes, but I forget why. I think there was another module that I deemed necessary. I'll try to update and see what happens.

EDIT: I updated, and everything seemed to go okay. I think it may have had something to do with Sprawlrunners not being compatible at the time? Unsure.

However, the importer seems to work now. Thanks!

ScottSilLew commented 1 year ago

Actually, this isn't the same issue, but it seems like it creates duplicate entries for skills and edges, for some reason. I can create a new issue, if needed.