search

arnonram / swade-npc-importer

Savage Worlds Stat-block importer for FoundryVTT
7 stars 8 forks source link

Importer does not use predefined Special Ability on import #81

Closed arnonram closed 2 years ago

arnonram commented 3 years ago

Occured once again on 0.1.10; seen it with Size, likely happens on others as usual.

Originally posted by @SalieriC in https://github.com/arnonram/swade-npc-importer/issues/73#issuecomment-952074734

SalieriC commented 2 years ago

Does not happen with burrow.

SalieriC commented 2 years ago

However it does happen with Fear.

arnonram commented 2 years ago

@SalieriC do you mean that if you have a Special Ability item it is not added to the imported character?

i cannot seem to reproduce it..

SalieriC commented 2 years ago

I tried to reopen and eventually commented on the closed ticket because I feel like this keeps raising the same questions over and over again. ^^' Take this for example (the huge in parenthesis doesn't make the difference): image The importer should use the item size from the compendium and update it on import. But instead it's creating a new item, not using any of the data from the existing one.

arnonram commented 2 years ago

ahh... the + sign before the number was giving me trouble. I believe in the style guide they only add a sign for negative numbers...

SalieriC commented 2 years ago

You're right but it's not working with negative values as well.

arnonram commented 2 years ago

Tested my fix and it looks like to work well for all kinds..

SalieriC commented 2 years ago

Yes, tested with the version on the 0.1.11 branch and it seems to be working great.

SalieriC commented 2 years ago

I must take this back unfortunately. I tried importing a creature with Size –2 (Small) and the importer did not use the predefined item from the compendium.

arnonram commented 2 years ago

ok, think i got it this time