search

arnoson / kirby-stats

Simple and privacy friendly web statistics for Kirby CMS.
MIT License
8 stars 0 forks source link

Fix event listeners, update k-stats-chart.vue to avoid overflow issues #17

Closed grommasdietz closed 10 months ago

grommasdietz commented 10 months ago

At least with zero data the svg label(s) were overlaying the Views / Visits navigation, making it unable to reach views.

Screenshot of the overflow issue
arnoson commented 10 months ago

awesome, thank your for your contribution!

arnoson commented 10 months ago

I'm not sure if I should create a new release after each PR or only if we collected a few changes? Are you using this plugin via composer or do you clone the latest version from github?

grommasdietz commented 10 months ago

I personally think bug fixes like the overflow issue are fine for collection, issues like the event listener logic may be more critical for a production build. I’m using a clone of the latest version from GitHub on my personal boilerplate to push commits and composer on a second project in progress.

Since the plugin is still in development we can use a work around for projects with composer:

  "repositories": [
    {
      "type": "vcs",
      "url": "https://github.com/arnoson/kirby-stats"
    }
  ],
  "require": {
    "arnoson/kirby-stats": "dev-main"
  },