search

arogozhnikov / demuxalot

Reliable, scalable, efficient demultiplexing for single-cell RNA sequencing
MIT License
23 stars 3 forks source link

`BarcodeHandler.from_file`: Pass down parameters #25

Closed mschilli87 closed 7 months ago

mschilli87 commented 7 months ago

While BarcodeHandler.__init__ has (optional) parameters to adjust barcode-related options (e.g. using non-CB SAM tags for the cell barcodes, like XC), the static from_file function called it without any of those parameters, making it impossible to adjust them when using that function. This is resolved by adding an optional keyword argument dictionary parameters to the static function and passing all argument provided therein, if any, down to the __init__ call.

This addresses one out of two issues raised in https://github.com/herophilus/demuxalot/issues/23.

closes #26

arogozhnikov commented 7 months ago

LGTM.

I'd merge this, but github says I don't have write access (will figure this out soon)

mschilli87 commented 7 months ago

@arogozhnikov: I guess this has something to do with the organisation settings of @herophilus. 🤷