arsbar24 / STAT545-hw-barton-alistair

Alistair's Assignments for STAT 545A
0 stars 0 forks source link

hw01 ready for grading #1

Open arsbar24 opened 7 years ago

arsbar24 commented 7 years ago

@vincenzocoia @gvdr @ksedivyhaley @joeybernhardt @mynamedaike @pgonzaleze @derekcho

mylinhthibodeau commented 7 years ago

Dear Alistair,

First of all, thank you so much for sharing interesting facts about yourself in your GitHub repository, it made it interesting for me to read.

I think you did an amazing job with the assignment ! Your README.md file has very nice photos and you illustrated multiple features Markdown (header, bullet points, italic, bold, making links, gif). You described your process, and the thinking behind your decision about the photo format.

Moreover, you went above and beyond in initiating on your own the gapminder data exploration and your gapminder-exploration.Rmd file is very informative and reveals that you have a good understanding of coding syntax in the R language. You might have some prior knowledge helping you and I know several students are just starting their journey on learning how to code with this class, but I still think you deserve some praises for the quality of your work. I also really liked that you provided your own socio-economic interpretation of the data.

Just as a side information and since I learned from reading your work, I thought it would only be fair for me to show you my gratitude by providing a little tip you might find useful. If you would like your R plots to appear in your R markdown document, you can use one of the resource from stat545 here.

For example

suppressPackageStartupMessages(library(tidyverse)) 
suppressPackageStartupMessages(library(gapminder))
knitr::opts_chunk$set(fig.width=4, fig.height=3)
p <- ggplot(gapminder, aes(x=year, y=lifeExp)) + geom_point()
p
dev.print(pdf, "your_plot.pdf")

Overall, I think the quality of your homework is outstanding and I think you should receive full marks !

Thank you again for sharing and I wish you good luck for this class.

Warm regards, My Linh Thibodeau

wswade2 commented 7 years ago

Hi Alistair,

Great job on your introduction. I especially liked that your page involved so many pictures/GIFs. Your exploration of the Gapminder dataset was very thorough. There is a box on the top of the readme file that just says output - pdf_document - default which is a bit distracting. But overall I think you did a good job.

I'll note how your homework compares to the rubric:

-provides a proper introduction of student to the class - CHECK -demonstrates experimentation with 4 or more aspects of the Markdown syntax - CHECK -student describes how they got the changes into README.md - CHECK -submitted a well-named R Markdown document with exploration of the Gapminder dataset and the rendered markdown file - CHECK -student offers a few reflections on their GitHub workflow and their experience with Markdown - CHECK -the homework submission issue follows the naming convention, includes the SHA, and there’s a link to the rendered .md for the Gapminder exploration - CHECK

My evaluation is that your submission is a CHECK PLUS.

derekcho commented 7 years ago

Hi @arsbar24 ! Here are some comments about your hw01:

Good looking README! Poor James Milner :( Looks like Barcelona have already won the league this year!

A few minor notes, you should get rid of the yaml (that table with output types on it) on the top of your README. Also, for aesthetic purposes, try resizing some of your images as well for a cleaner looking README file. Overall, good effort on the README!

For your gapminder exploration, it looks like you put in a lot of effort and definitely went above and beyond which was great to see! However, I am not sure that the document rendered the way that you expected. On GitHub, you cannot see all of the plots that you made in gapminder-exploration.Rmd unless I copy, paste, and run the code on my own RStudio. Try to use the .md file instead of the .Rmd file which should render the plots properly on GitHub. You can do this by clicking the gear icon beside knit -> Output Options -> Advanced -> Check the box labeled “Keep markdown source file”.

Note: your mark (check minus, check, check plus) will be distributed later.