hw09 ready for grading

[arsbar24]

Link to summary/reflections (good place to start)

Link to package

[swynes]

Hi there,

Very good job on the package. Unfortunately I don't have the background in machine learning to really evaluate the usefulness of your functions but I can say that the code is readable despite being fairly complex. I especially like how you included several if statements and how they contained feedback that was straightforward (other R error messages are often so cryptic).

In terms of other necessary components, you included a README, a vignette, and tests. Other small details like the inclusion of a license were also spot on.

Overall great work and good luck on the last assignment!

[santiagodr]

Hi @arsbar24, here are my comments!

• Great work on developing a new package from scratch. I find this way more complicated and ambitious, and is great to see that you succeed on this task!!!
• Your HW README is clear and linked to the package README and files.
• Your package README didn't provide instructions for installation, or links to the vignette. There is a good explanation of examples, but the output after fitting the functions that you created is not visible, I guess this is because your README is a .Rmd instead of an .md file.
• I find the same issue in your vignette my_vignette.Rmd file. Even though you included a very good explanation of the functionality of your package, the fact that this file is an Rmd doesn't allow me to see the output or plots that you mention. Maybe you forgot to render the Rmd to md/html file, or maybe you forgot to edit the gitignore manually to allow visualization of the rendered files. In any case, that's probably easy to fix and will allow a better visualization of the functionality of your package
• Unfortunately, I could not install your package, I tried devtools::install_github("arsbar24/RegularizedFits") but got an error, so I couldn't explored the functions and examples by myself. Maybe, you have a different route to install it?
• In terms of other HW requirements, you defined new functions with sensible defaults, and gave good documentation to them. You also created unit tests for each function. Also the functions are long, but well documented, including specific comments.
• You also provided a reflections section, with specific links to useful resources. Overall, great assignment!!! I learned a lot from the functions you created, and hope to explore them myself...

[derekcho]

Hi @arsbar24, here are some comments about your hw09:

Able to install properly: Yes At least one new function: Yes Used assertions to check function input: Yes Documented exported functions: Yes Includes three unit tests for each function: Yes Passes check: Yes README and vignette: Yes Reflections included: Yes

• You should leave instructions on how to install your package in the vignette. I was unable to install it using `devtools::install_github("arsbar24/RegularizedFits")’
• Good idea for a package, more complex than what was required and was implemented well
• Good error checking in functions, you are exhaustive and return useful error messages
• Vignette is well written with good examples and instructions on how to use reg.lm and crossval
• Excellent work overall, your package installs properly and runs smoothly.

Your grade will be emailed to you at a later date.