artfulrobot / uk.artfulrobot.civicrm.gocardless

A CiviCRM extension providing GoCardless integration to handle UK Direct Debits.
GNU Affero General Public License v3.0
5 stars 18 forks source link

Switch to doPayment() and stop using deprecated doTransferCheckout() #114

Closed mattwire closed 3 years ago

mattwire commented 3 years ago

CiviCRM will start outputting deprecated warnings from 5.39: https://github.com/civicrm/civicrm-core/pull/20384 and the function has been deprecated for a while.

All core processors have now been changed over - see example: https://github.com/civicrm/civicrm-core/pull/20328

You need to check for 0 amount and return payment_status/payment_status_id. Paypal is the only core processor that was using doTransferCheckout and you can see a "quick and dirty" initial refactor that allowed us to remove it here: https://github.com/civicrm/civicrm-core/pull/20030