artfulrobot / uk.artfulrobot.civicrm.gocardless

A CiviCRM extension providing GoCardless integration to handle UK Direct Debits.
GNU Affero General Public License v3.0
5 stars 18 forks source link

Warning when using D9 and Civi 5.38 #116

Closed Upperholme closed 3 years ago

Upperholme commented 3 years ago

I'm just setting up a new site using Drupal 9.1.10 and Civi 5.38.0

This extension is generating a warning on contribution pages where it is active:

Warning: Declaration of CRM_Core_Payment_GoCardless::doTransferCheckout(&$params, $component) should be compatible with CRM_Core_Payment::doTransferCheckout(&$params, $component = 'contribute') in require_once() (line 13 of sites/default/files/civicrm/ext/uk.artfulrobot.civicrm.gocardless/CRM/Core/Payment/GoCardless.php).

artfulrobot commented 3 years ago

@Upperholme are you ok to make a PR for that? This will not be to do with D9; but will be to do with Civi 5.38.

artfulrobot commented 3 years ago

This should be fixed by #117