recurring payments were not stopped after the specified number of installments

[petednz]

As part of our testing this I set up a Recurring Contribution for £1 weekly for 2 weeks.

Here are the entries in GoCardless

as you can see, the payments are continuing to be made, which is also what shows in my bank account :-( and on my Contribution Tab

civicrm_contribution_recur correctly shows the 2 installments. It has no End Date. Should it have had this set when the recurring payment was initially set up?

Can you pls advise on how to get this fixed. Many thanks

[artfulrobot]

This is true! The system should pass a count parameter when creating the subscription, if an end date/count is specified.

[petednz]

Will you be looking in to this or should we provide a PR (assuming client wants to proceed)

[artfulrobot]

I will be looking into it when I get some spare time, or you could pay me to do it sooner, but PRs always very welcome :smiley:

[stesi561]

I've written a patch - just in process of testing, then will submit a PR.

[artfulrobot]

@stesi561 Thanks for the PR. I added a test and merged https://github.com/artfulrobot/uk.artfulrobot.civicrm.gocardless/pull/36

[artfulrobot]

v1.5-beta includes this. Get it from the Releases page. (The main CiviCRM extension site will probably pick it up tonight, but it won't pick up the correct zip files so I have to fix that manually.)

Note: I have not tested it in the real world, be fab to know if you had and it worked, let me know!

[petednz]

I got this the other day in case that provides some indication it works

[artfulrobot]

Thanks!