search

artfulrobot / uk.artfulrobot.civicrm.gocardless

A CiviCRM extension providing GoCardless integration to handle UK Direct Debits.
GNU Affero General Public License v3.0
5 stars 18 forks source link

Users are unable to install if they previously used vedaconsulting gocardless #52

Closed samayres1992 closed 5 years ago

samayres1992 commented 5 years ago

When installing this version of gocardless I was unable to do so due to the table already existing, I disabled the extension for uk.co.vedaconsulting.payment.gocardlessdd as advised.

This change allows the user to install without having to uninstall the previous extension which causes data loss.

artfulrobot commented 5 years ago

Thanks for sharing the code. Could you clarify what this does?

For a site with veda's extension installed:

  1. install this one too: crash
  2. disable veda's, install this one: fine.
  3. uninstall veda's (losing data!), install this one: fine.

Or are you saying (2) crashes?

I think your code suggestion will mean that this extension re-uses the existing PaymentProcessorType (belonging to Veda's extension). This might avoid a crash, but I'm not sure it leaves things all sorted. I think we need a proper migration path for people using veda's old extension that would enable this extension to properly process the old mandates (recurring contribs) going forward. See https://github.com/artfulrobot/uk.artfulrobot.civicrm.gocardless/issues/4

samayres1992 commented 5 years ago

Thanks for clarifying, you're right - This change I made was put in place due to receiving errors when I was trying to install this extension after disabling the Veda extension.

I was operating under the assumption that this extension was built upon Veda gocardless, so it would work as an upgrade from one to the other. But if that's not the case, I don't think it works as a real solution, merely just resolves an install. Should I just close?

artfulrobot commented 5 years ago

originally this was built upon Veda's extension, however I soon realised I needed a fresh start because of an API upgrade, and my desire to refactor the code to separate the functioning from the UI.

I think close this issue. It probably needs some careful work on the other issue about an upgrade path.

artfulrobot commented 5 years ago

I'm going toclose this PR now. Feel free to re-open if you address the issues we discovered.