search

artfulrobot / uk.artfulrobot.civicrm.gocardless

A CiviCRM extension providing GoCardless integration to handle UK Direct Debits.
GNU Affero General Public License v3.0
5 stars 18 forks source link

Support weekly direct debit #59

Closed mattwire closed 4 years ago

mattwire commented 4 years ago

CiviCRM specifies a weekly membership/recur as "Every 7 day". But GoCardless doesn't understand that this is "Every 1 week". I had a similar problem in Smartdebit and ended created a (probably overcomplicated) function to map params: https://lab.civicrm.org/extensions/smartdebit/blob/master/CRM/Core/Payment/Smartdebit.php#L508-521

artfulrobot commented 4 years ago

Thanks @mattwire.

What happens with GC then if you set it up weekly? I'm sure I've done a recurring contrib on weekly before now. Is it membership-specific?

mattwire commented 4 years ago

I was only using this for testing - I only tested using a membership.

Started with membership configured for 1-day which doesn't work because GoCardless doesn't support daily. Then set Membership with 7-day and the signup still fails (using a standard contribution page) because GoCardless reports that "Interval dayly must be yearly/monthly/weekly".

artfulrobot commented 4 years ago

all clear now.

Gotta love the 'dayly' bit!

artfulrobot commented 4 years ago

I believe the above commit fixes this.