search

artfulrobot / uk.artfulrobot.civicrm.gocardless

A CiviCRM extension providing GoCardless integration to handle UK Direct Debits.
GNU Affero General Public License v3.0
5 stars 18 forks source link

Membership dates possibly broken in CiviCRM 5.19.1+ #60

Closed artfulrobot closed 4 years ago

artfulrobot commented 4 years ago

When running my tests against 5.19.1 I found them to be broken around membership dates.

This suggests something has changed in core.

I'm working on a new release to fix this.

artfulrobot commented 4 years ago

This seems to fix: https://github.com/artfulrobot/uk.artfulrobot.civicrm.gocardless/commit/f517096a643d5ab47f8ebcfd29582be3023dc72c

artfulrobot commented 4 years ago

If anyone is up for doing some testing on master branch for this, please let me know.

Honestly it's like a can of worms at the mo: there's lots pretty broken in the older Contribution code and the newer code (like Payment.create) isn't ready yet, at least not in 5.19.

Upperholme commented 4 years ago

I'm open to testing this out if I usefully can, as memberships are important to me, and I'm also keen to be able to update Civi, to 5.19.2 now, with the security patches. Not sure what I'm looking for though. Are you saying the that the current release doesn't work with 5.19.x re: membership dates, and the master branch does?

artfulrobot commented 4 years ago

@Upperholme What I found is that the tests failed - the one that checks the membership date was updated.

It might be the test that's at fault (@aydun - any thoughts?), but I don't know.

The current master passes the tests. If you want to test it then you'll need to download the zip (or do it via git) but then you'll need to run composer install in the extension dir to get the vendor dir populated.

You'd be looking to check that when a payment comes in, membership end date is updated as expected.

Nb. I have also put in a bit of effort towards documenting payment processors - I feel we really need some more documentation here as every processor seems to do things differently.

artfulrobot commented 4 years ago

I've made further tweaks, tests passing on master. Going to release 5.19beta. Reopen this if a problem.