Correct payment_instrument_id and payment_type values in processor definitions.

artfulrobot / uk.artfulrobot.civicrm.gocardless

A CiviCRM extension providing GoCardless integration to handle UK Direct Debits.

GNU Affero General Public License v3.0

5 stars 18 forks source link

Closed artfulrobot closed 4 years ago

artfulrobot commented 4 years ago

It seems that both the Payment Processor Type and the Payment Processor records were not set correctly historically:

payment_type is defined as 1 = credit card, 2 = direct debit. So we should be using 2.
payment_instrument_id seems to have defaulted to 1 (i.e. credit card unless you have a non-standard install), but should point to the instrument created for GoCardless.

I don't think this will have affected anything but it should be corrected.

artfulrobot commented 4 years ago

Closing as fixed in 1.9.2beta2, will make 1.9.2