Time limit for pending recurring contributions

[mattwire]

Given that it is stated here https://developer.gocardless.com/api-reference/#core-endpoints-redirect-flows that redirect flows expire after 30 minutes shouldn't the Job.Gocardlessfailabandoned "fail" them after 30 minutes instead of 24 hours?

[artfulrobot]

Yes, thanks @mattwire that makes sense.

The default expiry is set in _civicrm_api3_job_Gocardlessfailabandoned_spec(). We should update the documentation (README) too.

I'd favour a more cautious aproach of 0.6 hours - i.e. something slightly over 30 mins. We don't want to reduce the window ourselves - e.g. someone gets to the page where they enter their details, goes off to find their card, gets distracted...

Also, do you think we should allow an extra hour for that poor person who

• starts a redirct flow at 01:59
• clocks go forward 1 hour at 02:00
• their redirect flow gets invalidated by cron
• they try and fail to complete redirect flow

Because the comparison is just done with activity date time strings and date(Y-m-d H:i:s)

I don't really mind, just noting the possibilities.

[mattwire]

I'm going to close this as I realise it's already available as a parameter to the job. Also you can easily detect a failed vs. a successful signup because it goes Pending->In Progress as soon as it is setup.

[artfulrobot]

Yeah, but your failed metrics will include those in process of submitting the forms. Which is likely a small error but maybe still important depending on what you do with the result! I think still useful to reduce the default timeout.

[mattwire]

Thanks @artfulrobot :-)