search

asafdav / ng-s3upload

Upload to S3 using AngularJS
MIT License
190 stars 83 forks source link

fix bucket error #14

Closed leonzinger closed 10 years ago

leonzinger commented 10 years ago

When doing eval on the bucket attribute in angular 1.2.14 instead of the value iv'e got "0". Without eval i get the bucket as needed

asafdav commented 10 years ago

Hi, Can you please post here your code that didn't work as expected?

Thank you

leonzinger commented 10 years ago

When i passed the bucket name in the attribute it ended up as 0 value. When i have debugged the code i found out that it fails to scope.$eval the attrs.bucket as it is already a string

leonzinger commented 10 years ago

i have seen a post request to amazon went out as something like that http://0.aws.amazon.com

leonzinger commented 10 years ago

Sorry for mistake, i have misunderstood the meaning of the bucket attribute. it should receive a model value and not a direct string :)

asafdav commented 10 years ago

It doesn't have to be a model value, you can use any string you'd like, but you have to wrap it with ' '.

Thanks! Asaf

On Sat, Mar 15, 2014 at 9:43 PM, Leon Zinger notifications@github.comwrote:

Sorry for mistake, i have misunderstood the meaning of the bucket attribute. it should receive a model value and not a direct string :)

Reply to this email directly or view it on GitHubhttps://github.com/asafdav/ng-s3upload/pull/14#issuecomment-37735904 .