Fixes for s3 api, Added events, Bootstrap3 progressbar, extra headers

asafdav / ng-s3upload

Upload to S3 using AngularJS

MIT License

190 stars 83 forks source link

Fixes for s3 api, Added events, Bootstrap3 progressbar, extra headers #15

Open dotansimha opened 10 years ago

dotansimha commented 10 years ago

Changes:

Fixes for s3 API (changed the "key" to "AWSAccessKeyId")
Change progressbar template to work with Bootstrap 3
Added events for start upload, upload done, upload failed
Added ability to add custom headers for upload request.
Changed HTTPS to HTTP to support non-https sites

Usage example:

      $scope.s3UploadOptions =
      {
          getOptionsUri: s3ErasOptionsUri,
          folder: "",
          acl: "private",
          uploadStartCallback: function()
          {
          },
          uploadDoneCallback: function(fileUrl, fileKey)
          {
          },
          uploadErrorCallback: function()
          {
          }
      };

asafdav commented 10 years ago

Hi there, few questions: 1) Why did you change the url to http instead of https ? It shouldn't be a problem to access secured resources from an unsecured resource, but it doesn't work the other way around. 2) Why did you change "key" name ? I'd rather leave it as is to keep backward compatibility 3) I just merged another pull request that added custom events to the upload service, would you mind look at it and let me know if it suits your need ?

dotansimha commented 10 years ago

Hi, 1) actualy changed it because of some problems I have specific in my enviroment that related to the https... I can be reversed to https. 2) I changed the key becuase the current API required that the name of the property will by AWSAccessKeyId... I dont think that backward compatibility is required as the "key" is not a valid property in S3 right now... 3) It actually suits my needs and looks good.

dotansimha commented 10 years ago

Also, accessing from HTTP to HTTPS might cause some errors related to Cross Origin. I think it should be a configuration option..

asafdav commented 10 years ago

Hi Dotan, Do you mind updating your code following our discussing here ? I mean remove the code duplications and adjust to the latest version of s3Upload ?

I'll be more than happy to merge your pull request afterwards.

asafdav commented 10 years ago

Any progress ?

jonahglover commented 9 years ago

Were these issues ever resolved?

asafdav commented 9 years ago

Which issue ? we added a lot of features since then .