search

asafdav / ng-s3upload

Upload to S3 using AngularJS
MIT License
190 stars 83 forks source link

The way of providing policy object as scope variable. #48

Closed Serhioromano closed 9 years ago

Serhioromano commented 9 years ago

I have my own service around $http. This service set special headers, and authorisation before get policy. So I cannot provide url. So I made that you have another option when you can set policy with you got as an object with your own request. The only problem for now is that the way you are dialing with attributes, is not 2 way and this parameter have to be resolved before assignment. That is ok for me because I use router ui and I can resolve things.

And I am sorry for readme file. My github client automatically stripped invisible symbols at the end of lines and formated it for github standards. basically I only added new line describing new feature.

asafdav commented 9 years ago

See my minor comments, please fix and I'll be happy to merge. Thanks!

Serhioromano commented 9 years ago

Done.

asafdav commented 9 years ago

Thank you, awesome pull request.