search

asafdav / ng-s3upload

Upload to S3 using AngularJS
MIT License
190 stars 83 forks source link

Various Fixes #55

Closed QuentinFchx closed 8 years ago

QuentinFchx commented 9 years ago

What's in:

Templates

Use bootstrap helper class hidden Fix ng-classdeclared twice Fix margin-topon wrong element Lint HTML

Config

Global config for uploads Being able to pass custom theme

Misc

Fix modules being overriden https://github.com/angular/angular.js/issues/1779

// file.js
angular.module('ngS3upload.config', [])
// file2.js
angular.module('ngS3upload.config', []) // the empty array overrides everything

Closes #43

asafdav commented 9 years ago

Hi, can you please squash your commits ?

steverob commented 9 years ago

@QuentinFchx @asafdav would love to see this merged :+1:

QuentinFchx commented 9 years ago

Wow, completely forgot this one. Will do !

QuentinFchx commented 9 years ago

Done

asafdav commented 9 years ago

Hi @QuentinFchx, First of all, thank you so much for this pull request, it's awesome! I reviewed your code, added small comments, can you please go over it? I'll be happy to merge this one!

asafdav commented 9 years ago

Hi @QuentinFchx, would you be able to go over my comments and see if you can push a fix ? Thanks!

QuentinFchx commented 9 years ago

Yep, sorry I was on vacations. I will try to do it today !

asafdav commented 8 years ago

Sorry for the delay @QuentinFchx, thanks a lot!