search

asafdav / ng-s3upload

Upload to S3 using AngularJS
MIT License
190 stars 83 forks source link

Some new configuration options #64

Open joelturnbull opened 9 years ago

joelturnbull commented 9 years ago

I used your directive to replace an old backbone video uploader in our app, but we had some specific needs that I thought I'd submit as new configuration options. I have each of these new options split out as a separate branch if you prefer them that way. Thanks!

  1. We needed to tweak the UI a bit so I added the ability to set the templateUrl to file outside of the project.
  2. For whatever reason, our s3 is setup to forbid requests having the Content-Type header so I added an option to suppress adding that.
  3. Last, we save our files using the original filename so we can display that to the user who uploaded them. Added the ability to preserve and save the file using the original filename.
asafdav commented 9 years ago

Hi @joelturnbull, Thank you for this pull request, I want to merge it. I'm about to merge #55 that already tackles your first item so after I merge it, I'll take another look at your pull request and see how to combine it.

Thanks again !

joelturnbull commented 9 years ago

Great! Thanks @asafdav

steverob commented 8 years ago

@joelturnbull @asafdav would love to see the originalFileName option feature being merged.

Is there anyway to achieve that with the current version btw?

Thanks! :heart:

asafdav commented 8 years ago

Hi @steverob, thanks for the reminder. I merged #55 today, I will try to find some time and go over this pull request soon.