asafdav / ng-s3upload

Upload to S3 using AngularJS
MIT License
190 stars 83 forks source link

Add $emitted events to uploader service #8

Closed partap closed 10 years ago

partap commented 10 years ago

Thanks for making this module available... it was (almost) exactly what I needed!

I added some events to the service, because I needed my parent controller to be able to tell the status of the upload:

partap commented 10 years ago

Oh yeah, one more thing: If you want to cancel the upload, be sure to wrap the abort() call in a timeout to avoid a nested $apply exception.

ex:

$scope.cancelUpload = function () {
  $timeout( function () {
    $scope.xhr.abort();
  }, 0);
};
neekers commented 10 years ago

+1

Baltazore commented 10 years ago

:+1: Useful feature, especially for validations workflow

leonzinger commented 10 years ago

+1

asafdav commented 10 years ago

Hi all, thank you for the feedback and for the amazing work.

My schedule is quite packed lately, I'll do my best to look into it and merge it to the project ASAP.

On Mon, Mar 10, 2014 at 4:33 PM, Leon Zinger notifications@github.comwrote:

+1

Reply to this email directly or view it on GitHubhttps://github.com/asafdav/ng-s3upload/pull/8#issuecomment-37188052 .

oivoodoo commented 10 years ago

+1

asafdav commented 10 years ago

Thank you for this amazing pull request, sorry it took me so long.

asafdav commented 10 years ago

BTW, would you mind updating the readme file accordingly ?

Thanks!