Fixed for more recent versions of SimpleSAMLphp

infostreams commented 7 years ago

Newer versions of SimpleSAMLphp don't have the SimpleSAML_autoload function anymore.

asasmoyo commented 7 years ago

Wow thanks for the PR! Have you test this on your side? Sorry I do not maintain Yii app with Simplesamlphp anymore so I can't test it.

infostreams commented 7 years ago

Yeah, without this code it doesn't work on my side. The reason being that the function SimpleSAML_autoload doesn't exist anymore in newer versions of SimpleSAMLphp. What this code does is

First it checks if the function SimpleSAML_autoload exists anyway. If it exists, it does the exact same thing it did before, so there's no change in functionality.
If the function does not exist, it checks if Composer added an autoload class, and then registers that autoload class with Yii. This is the new codepath that I needed to add for my situation. Otherwise, it wouldn't start the authentication flow and my application wouldn't authenticate with the identity provider (I'd get a fatal error about a non-existing function SimpleSAML_autoload instead)

So yes, it is tested. With this code it works in newer versions of SimpleSAML. Without this code, it doesn't.

asasmoyo commented 7 years ago

Nice! Thanks a lot. Will merge it.

asasmoyo / yii-simplesamlphp

Fixed for more recent versions of SimpleSAMLphp #3