search

asciidoctor / asciidoctor-intellij-plugin

AsciiDoc plugin for products on the IntelliJ platform (IDEA, RubyMine, etc)
https://intellij-asciidoc-plugin.ahus1.de/
Apache License 2.0
347 stars 146 forks source link

Antora component schema should support boolean type for `prerelease` and the `ext` property #1254

Closed ahus1 closed 1 year ago

ahus1 commented 1 year ago

Observed vs. expected behavior

When opening an antora.yml file with 

prerelease: true

or 

ext:
  collector:
   ...

the IDE shows a warning, as the schema for prerelease doesn't allow a boolean value, and the property ext is unknown.

Steps to reproduce

Use: antora.yml from the Eclipse Che docs

Environment

Plugin Version: 0.38.4

cc: @themr0c

ahus1 commented 1 year ago

Fixed in upcoming release.

ahus1 commented 1 year ago

This is part of pre-release 0.38.5.

The pre-release of the plugin is available from GitHub releases and the IntelliJ AsciiDoc EAP repository.

mojavelinux commented 1 year ago

Keep in mind the ext key is still in alpha as only Antora Collector supports it. That will likely change when Antora Collector goes final.

ahus1 commented 1 year ago

This change only prevents the "ext" property in the YAML file to show with a warning. That warning might otherwise confuse users.

mojavelinux commented 1 year ago

Ack. Just wanted to give you a heads up that we still haven't made a final decision about the name yet. We also haven't yet decided whether this is an open schema or whether the keys are fixed (or if there is an reserved part that is an open schema). We're letting experience be the guide here.