search

askfiy / visual_studio_code

A `neovim` theme that highly restores `vscode`, so that your friends will no longer be surprised that you use `neovim`, because they will think you are using `vscode` ..
Mozilla Public License 2.0
169 stars 11 forks source link

The 'light' background can't work when setting colorscheme to the 'visual_studio_code' #8

Open alexya opened 4 months ago

alexya commented 4 months ago

I like the Visual Studio Code default color scheme Light+ very much and found that you are creating a color scheme including light and dark like Visual Studio Code for Neovim. Thank you very much.

macOS: Sonoma 14.4.1 iterm2: Build 3.4.23 NVIM v0.9.5

My config is here: https://github.com/alexya/josean-dev-env/tree/main/.config/nvim

I set to use the <leader>bg to switch background, and <leader>co to change the colorscheme. (The leader is space key) Please watch the repro video, when changing from the modus colorscheme to tokyonight, it worked fine. But next when I tried to switch to visual_studio_code, it failed. And changed the background to 'dark' automatically. Even if I forced to set it to 'light', it still shows as 'dark' with incorrect color. All the other colorscheme can work fine under 'light' and 'dark'.

I tried to rm -rf ~/.local/share/nvim and opened Neovim again. The problem still existed.

I don't know why. I am not good at debugging Neovim and its plugins. Any help will be much appreciated. thx.

repro video https://github.com/askfiy/visual_studio_code/assets/2831220/82280b5d-ed54-412f-8ded-c5eaeb4e3700
askfiy commented 4 months ago

Predictably, the theme uses the dark color scheme by default.

When you use the colorscheme command to modify the color scheme, essentially it runs colors/visual_studio_code.vim file.

The workaround is that you need to manually call setup and set mode to light, but not use the vim.cmd([[colorscheme visual_studio_code]]) command.

It should take effect when you manually call the [[colorscheme visual_studio_code]] command in the command line.

alexya commented 3 months ago

The workaround is that you need to manually call setup and set mode to light

Do you mean set like this? https://github.com/alexya/josean-dev-env/blob/main/.config/nvim/lua/josean/plugins/colorscheme.lua#L17 I ever did it, but it still can't work.