search

astro-datalab / notebooks-latest

Default set of Data Lab notebooks, by DL team and contributed by users
BSD 3-Clause "New" or "Revised" License
57 stars 48 forks source link

Add new GMOS DRAGONS data reduction NB #167

Closed rnikutta closed 1 year ago

rnikutta commented 1 year ago

@jacquesalice could you please review this PR? I made only minimal changes to this latest version by Susan and Vini (e.g., update datestring, fixed a few typos, added "This will take 2 minutes" comments to two long-running cells, and cleared the outputs (b/c otherwise the NB swells to 7.5 MB instead of 200 KB or so without the outputs). Also added rendered HTML version.

jacquesalice commented 1 year ago

Oh, sorry, I left the outputs in. I'll remove them and upload a new version

jacquesalice commented 1 year ago

Done

rnikutta commented 1 year ago

@jacquesalice Good catch; the cleanup cell doesn't work for me either. The reasons seems to be that the working directory is the root dir of the user, not the dir where the NB is. (but I'm somewhat surprised that the wget cell that fetches the data seems to be working fine. And it doesn't look like a permissions issue because in the terminal the files are owned by the user, and I can delete them there.

I'll email Vini and Susan, and Mike (maybe it's something with the DRAGONS kernel). Let's hold off on merging for the moment.