astro-datalab / notebooks-latest

Default set of Data Lab notebooks, by DL team and contributed by users
BSD 3-Clause "New" or "Revised" License
60 stars 49 forks source link

Add "BaryonicAcousticOscillations" project on extra-galactic science #169

Closed JasonWooo closed 1 year ago

JasonWooo commented 1 year ago

Added notebook "BaryonicAcousticOscillation_BOSSDR12_20230518", which is a detailed instruction on characterizing the baryonic acoustic oscillations using SDSS DR12 data using two-point correlation functions.

kadrlica commented 1 year ago

Thanks @JasonWooo!

As context for others: this submission is part of the final project for ASTR285 at UChicago. I plan to review the notebook before requesting review from a repo admin.

kadrlica commented 1 year ago

@JasonWooo I think this notebook would be ready for Data Lab review with some fairly minor changes. Let me know if you'd like to go forward with that process. I can leave some suggestions here and/or make some changes directly to the notebook.

JasonWooo commented 1 year ago

Sure! I will be traveling tomorrow but I'll let you know once I'm settled down to work on things!

kadrlica commented 1 year ago

@jacquesalice and @rnikutta would you have a chance to give this notebook a review? Thanks!

rnikutta commented 1 year ago

Hi @kadrlica and @JasonWooo , gladly! Thanks for the NB. I'm still on vacation but will try to take it for a spin on Thu or Fri.

rnikutta commented 1 year ago

Really nice NB @JasonWooo and @kadrlica , many thanks! Below my comments in addition to @jacquesalice 's, trying not to repeat any:

Loading Galaxy Data

Load the CMASS data sample from the Baryon Oscillation Spectroscopic Survey (BOSS). Only the Southern half of the survey is used. The analysis could extend to the full dataset, but this is sufficient for the purposes of seeing the BAO. The dataset is pre-selected for Luminous Red Galaxies (LRGs) using two different color selections for low-redshift (𝑧<0.45) and high-redshift (𝑧>0.45) galaxies. The specifics are noted in this SDSS page.

We get the FITS file from the sdss_dr12 File Service at Data Lab:

remdir = 'sdss_dr12://boss/lss/'  # remote
locdir = './data/'                # local
fname = 'galaxy_DR12v5_CMASSLOWZTOT_South.fits.gz'

if not os.path.exists(locdir+fname):
    res = sc.get(fr=remdir+fname,to=locdir+fname,verbose=False)

Load the data and print the fields and number of objects in the dataset.

data = fits.open(locdir+fname)[1].data
print(data.dtype)
print(f'{len(data)} objects in data set')
JasonWooo commented 1 year ago

Hi @kadrlica @jacquesalice @rnikutta ,

Thank you all for the feedback and suggestions! I've made changes to the notebook, incorporating all the changes and fixing all the issues that were pointed out. Two notes from me:

That's it from me! Please do let me know if there is anything else I can do. Have a good weekend!

galaxyumi commented 1 year ago

Hi @JasonWooo and @kadrlica, as a new member, I just reviewed your NB. The contents are great. Thanks for your contribution!

I have only minor suggestions:

  1. In the Background, Baryonic Acoustic Oscillations (BAO) -> Baryonic Acoustic Oscillations (BAOs)
  2. Please double check the year of the Eisenstein's paper. It seems that it should be Eisenstein et al. (2005), not Eisenstein et al. (2004).
  3. In Magnitude section, could you specify a section, or a table, or equations for this statement: "The magnitudes are given in five different versions of fluxes, using definitions provided in Eisenstein et al 2004."?
  4. Can you replace the link for Anderson et al. (2012) to the published version (https://ui.adsabs.harvard.edu/abs/2012MNRAS.427.3435A/abstract), not the arXiv version?
JasonWooo commented 1 year ago

Hi @galaxyumi,

Thank you for all the valuable feedback! I incorporated them into the notebook and pushed to my fork of notebooks-latest. For suggestion #4 in particular, I also changed all arxiv links to published versions from their respective journals.

Thank you all again for following through with this project. Please let me know if there is anything else I can do @kadrlica @rnikutta @jacquesalice

jacquesalice commented 1 year ago

Thanks @JasonWooo ! It looks great. Merging to master now :)