search

astro-datalab / notebooks-latest

Default set of Data Lab notebooks, by DL team and contributed by users
BSD 3-Clause "New" or "Revised" License
60 stars 49 forks source link

Ipywidgets matplotlib.pyplot updates #189

Closed marcodatadev closed 1 year ago

marcodatadev commented 1 year ago

These changes are needed due to updates in the Ipywidgets and Matplotlib libraries.

We are fixing the errors reported by Justine Schane and Robert Sparks, where the slides were duplicating images.

marcodatadev commented 1 year ago

Hi @jacquesalice and @rnikutta

Could yo please review this PR?

Regards,

Marco Moreno

rnikutta commented 1 year ago

Hi @marcodatadev , thank you for the PR. I've just cloned your branch and ran the NB 06_EPO/TeenAstronomyCafe/07_Large_Scale_Structure_of_the_Universe/Large_Scale_Structure_of_the_Universe.ipynb on our NB server (https://datalab.noirlab.edu/devbooks). Unfortunately, for every plot it only prints "Loading widget", but doesn't show any plot.

ipywidgets has always been a bit brittle in our experience, so maybe it's a specific version incompatibility?

Please advise how you want to proceed on this notebook. (the other updates are to NBs in the e-TeenAstronomyCafe, and they are meant to be run on Collab, not on our NB server. Thus, we are not testing them).

Thanks!

marcodatadev commented 1 year ago

Hi Robert,

Thank you for your review. I appreciate it.

Could you be so kind as to ignore the changes in NB 06_EPO/TeenAstronomyCafe/07_Large_Scale_Structure_of_the_Universe/Large_Scale_Structure_of_the_Universe.ipynb and only update the changes in the NBs in the e-TeenAstronomyCafe? I tested all the changes in the NBs in e-TeenAstronomyCafe , and they are working properly.

Thanks

Regards/Saludos,

Marco Moreno Web Projects Coordinator | Enciso Systems A: Calle 35B # 19D - 40 | Villavicencio, Colombia C: +57 317 6394548 | W: encisosystems.com

✨ Follow us: encisosystems.com/social ✨

El mié, 26 jul 2023 a la(s) 09:29, Robert Nikutta @.***) escribió:

Hi @marcodatadev https://github.com/marcodatadev , thank you for the PR. I've just cloned your branch and ran the NB 06_EPO/TeenAstronomyCafe/07_Large_Scale_Structure_of_the_Universe/Large_Scale_Structure_of_the_Universe.ipynb on our NB server (https://datalab.noirlab.edu/devbooks). Unfortunately, for every plot it only prints "Loading widget", but doesn't show any plot.

ipywidgets has always been a bit brittle in our experience, so maybe it's a specific version incompatibility?

Please advise how you want to proceed on this notebook. (the other updates are to NBs in the e-TeenAstronomyCafe, and they are meant to be run on Collab, not on our NB server. Thus, we are not testing them).

Thanks!

— Reply to this email directly, view it on GitHub https://github.com/astro-datalab/notebooks-latest/pull/189#issuecomment-1651922551, or unsubscribe https://github.com/notifications/unsubscribe-auth/A2ZSWTF2UB4YT6XTMC35SVDXSESVHANCNFSM6AAAAAA2RVCVFE . You are receiving this because you were mentioned.Message ID: @.***>

rnikutta commented 1 year ago

Hi @marcodatadev Of course! But could you please add another commit to your PR where you undo/revert the changes to the NB 06_EPO/TeenAstronomyCafe/07_Large_Scale_Structure_of_the_Universe/Large_Scale_Structure_of_the_Universe.ipynb

Then I can merge the rest very simply.

Thanks!

marcodatadev commented 1 year ago

Hi @rnikutta,

I reverted the commit, and the PR has been updated. The NBs with changes are all from the folder e-TeenAstronomyCafe.

Thanks

marcodatadev commented 1 year ago

Many thanks @rnikutta

Regards/Saludos,

Marco Moreno Web Projects Coordinator | Enciso Systems A: Calle 35B # 19D - 40 | Villavicencio, Colombia C: +57 317 6394548 | W: encisosystems.com

✨ Follow us: encisosystems.com/social ✨

El vie, 28 jul 2023 a la(s) 17:14, Robert Nikutta @.***) escribió:

Merged #189 https://github.com/astro-datalab/notebooks-latest/pull/189 into master.

— Reply to this email directly, view it on GitHub https://github.com/astro-datalab/notebooks-latest/pull/189#event-9952622046, or unsubscribe https://github.com/notifications/unsubscribe-auth/A2ZSWTFAF6BEOTR2Z423P43XSQ2TNANCNFSM6AAAAAA2RVCVFE . You are receiving this because you were mentioned.Message ID: @.*** com>